Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use response_time_percentile for <name>_stats.csv file instead of current_response_time_percentile #1197

Merged
merged 1 commit into from
Dec 16, 2019

Conversation

mehta-ankit
Copy link
Contributor

Using --csv flag in 0.13.3 version of locust (after #1146 was merged) only prints percentiles in the sliding window of CURRENT_RESPONSE_TIME_PERCENTILE_WINDOW. This happened because instead of using get_response_time_percentile() function i used get_current_response_time_percentile() in requests_csv() function.

@mehta-ankit
Copy link
Contributor Author

@heyman @cyberw Made a small mistake in my previous PR (refactoring of CSV related code) that merged recently. Created an issue to track it:
#1198

@codecov
Copy link

codecov bot commented Dec 16, 2019

Codecov Report

Merging #1197 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1197   +/-   ##
=======================================
  Coverage   78.57%   78.57%           
=======================================
  Files          20       20           
  Lines        1960     1960           
  Branches      307      307           
=======================================
  Hits         1540     1540           
  Misses        341      341           
  Partials       79       79
Impacted Files Coverage Δ
locust/stats.py 84.35% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c954bf...2744d83. Read the comment docs.

@cyberw
Copy link
Collaborator

cyberw commented Dec 16, 2019

lgtm

@cyberw cyberw merged commit 6ba31c8 into locustio:master Dec 16, 2019
@mehta-ankit
Copy link
Contributor Author

@cyberw Should i close the bug or you want to close it as fixed for history purposes ?

@cyberw
Copy link
Collaborator

cyberw commented Dec 16, 2019

I closed it now (implicitly it is considered fixed and will be included in the release notes for the next release)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants