Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo #117

Merged
merged 1 commit into from
Dec 5, 2013
Merged

fix typo #117

merged 1 commit into from
Dec 5, 2013

Conversation

sanga
Copy link
Contributor

@sanga sanga commented Dec 5, 2013

Apparently test coverage for this is also not what it should be, otherwise this would've been caught. I can look into providing some tests for that this weekend perhaps (time allowing).

In other news I think this takes the record for my smallest bugfix ever :)

Jahaja added a commit that referenced this pull request Dec 5, 2013
@Jahaja Jahaja merged commit d8c321d into locustio:master Dec 5, 2013
@Jahaja
Copy link
Member

Jahaja commented Dec 5, 2013

Thanks! Yeah, we'll need to improve the test coverage.

@heyman
Copy link
Member

heyman commented Dec 5, 2013

Yeah, I was about to create a test case that would trigger the locust_error event the other day when you did the #114 pull request, but realized that we have a big catch-all try-catch that makes it a little tricky.

While writing this comment I couldn't help myself from implementing a test case covering this anyway :).

I introduced a private variable Locust._catch_exceptions which defaults to True, but I'm also thinking that perhaps we should add a command line option for disabling the exception catching, since it might be nice to use during development of your load testing scripts.

@sanga
Copy link
Contributor Author

sanga commented Dec 5, 2013

"While writing this comment I couldn't help myself from implementing a test case covering this anyway :)" Excellent. Cheers

"thinking that perhaps we should add a command line option for disabling the exception catching": well those exceptions are still logged right? I've usually just fixing such problems by dumping those logged exceptions out to the terminal (of course locust spits a few of them - so catch_exceptions=False would make that nicer).

But yeah, I think some things could be done to make scenario development (and maintainence) easier. For example dropping into a debugger on exceptions would be nice (I guess the catch_exceptions thing would help with this) as it's not always immediately obvious as to the source of the exception. Though I have some hazy recollection debugging gevent to not be so trivial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants