Fix rounding error when spawning users from multiple locust classes #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1113 +/- ##
==========================================
- Coverage 73.16% 72.94% -0.22%
==========================================
Files 18 18
Lines 1755 1763 +8
Branches 257 261 +4
==========================================
+ Hits 1284 1286 +2
- Misses 408 418 +10
+ Partials 63 59 -4
Continue to review full report at Codecov.
|
|
LGTM. Not loving the variable name "amount", but that was there before the PR so whatever :) |
I agree. |
This was referenced Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #848 and is an alternative implementation to #860. It's simpler but less sophisticated.
With this PR one could still get an uneven distribution of Locust classes when killing locusts. For example if one has multiple Locust classes and then kills a single user one by one by changing the number of locusts multiple times and decreasing the number by one each time. I don't think this is a big issue. It could be fixed later by rewriting the logic of the
LocustRunner.kill_locusts()method to - instead of usingweight_locusts()to get a list of classes to remove - useweight_locusts()to get a list of the new distribution and then diffing the current distribution to the new one and killing the locusts needed to achieve the new distribution.