Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding TCP Keep Alive to guarantee master-slave communication after i… #1101

Merged
merged 1 commit into from
Oct 1, 2019
Merged

Adding TCP Keep Alive to guarantee master-slave communication after i… #1101

merged 1 commit into from
Oct 1, 2019

Conversation

AnotherDevBoy
Copy link
Contributor

This PR is a copy of #1020 (obsolete due to merge conflict issues)

For context, the cloud infrastructure my company uses has a firewall that closes idle connections after 5 minutes. For us, that means that if we leave a test running for a while and come back to it, we are unable to control the slaves through the master UI.

If you look through the comments PR 740, you can see that this is easily fixed by adding keep alive at the ZMQ socket level.

We thought that PR 927 would make the change redundant but, after testing Locust 0.11.0 (which includes the change) we were able to reproduce the problem again pretty consistently.

@AnotherDevBoy AnotherDevBoy mentioned this pull request Oct 1, 2019
Closed
mbeacom
mbeacom approved these changes Oct 1, 2019
View reviewed changes
Copy link
Member

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :shipit:

@mbeacom mbeacom merged commit c95dda3 into locustio:master Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbeacom mbeacom mbeacom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AnotherDevBoy @mbeacom @Riot-p4x0s