Allow None response time for requests #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1088 +/- ##
==========================================
+ Coverage 72.69% 74.08% +1.39%
==========================================
Files 18 18
Lines 1765 1779 +14
Branches 262 263 +1
==========================================
+ Hits 1283 1318 +35
+ Misses 420 399 -21
Partials 62 62
Continue to review full report at Codecov.
|
…s and "only async". Add test for master total stats with none response times.
heyman
reviewed
Oct 21, 2019
| @@ -159,6 +159,35 @@ class MyTestLocust(Locust): | |||
| s = master.stats.get("/", "GET") | |||
| self.assertEqual(700, s.median_response_time) | |||
|
|
|||
| def test_slave_stats_report_with_none_response_times(self): | |||
There was a problem hiding this comment.
Nice with tests that tests the whole cycle with master/slave communication!
It'd be nice to also have much simpler test in test_stats.py that just tests the None response time functionality for StatsEntry.
cyberw
added
hacktoberfest
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1087