Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow options to be passed to locust in docker, update docs #1083

Merged
merged 1 commit into from
Oct 1, 2019
Merged

Allow options to be passed to locust in docker, update docs #1083

merged 1 commit into from
Oct 1, 2019

Conversation

max-rocket-internet
Copy link
Contributor

In this PR I am:

  • Adding a new env var so users can pass options to locust in docker image. This means standalone mode with no web is now possible. Great for running as k8s Job.
  • Updating docker documentation with new LOCUST_OPTS env var and a couple extra examples for how to run your tests.

Does it make sense? Is that OK?

@hjacobs
Copy link

hjacobs commented Sep 12, 2019

LGTM

@max-rocket-internet max-rocket-internet mentioned this pull request Sep 27, 2019
Merged
@max-rocket-internet
Copy link
Contributor Author

@mbeacom, would you mind reviewing this?

mbeacom
mbeacom approved these changes Oct 1, 2019
View reviewed changes
Copy link
Member

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :shipit:

@mbeacom mbeacom merged commit 3663991 into locustio:master Oct 1, 2019
@max-rocket-internet max-rocket-internet deleted the docker_fixes branch October 1, 2019 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbeacom mbeacom mbeacom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@max-rocket-internet @hjacobs @mbeacom