-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to exclude some statistics from aggregation #2955
Comments
fix: expected environment param default types fix: using Optional syntax
note it's not clear why Mypy check does the error
those lines are not even touched in this PR. |
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This issue was closed because it has been stalled for 10 days with no activity. This does not necessarily mean that the issue is bad, but it most likely means that nobody is willing to take the time to fix it. If you have found Locust useful, then consider contributing a fix yourself! |
Prerequisites
Description
Currently if our locust script track additional statistics via custom type event, it cannot be excluded from the aggregated line.
Ideally it should be possible to define via script somewhere (via annotation etc...) which metrics are ignored for the aggregation computation, or via ui (similarly to the columns selector).
The reason is that those metrics are mainly to track statistic like "cache missed etc..." detected from CDN response header and so shouldn't be part of the aggregated statistic line data.
Note: the solution is pretty trivial if we hack in the code as it's mainly to add an condition on this line to exclude specific method or name
https://github.com/locustio/locust/blob/master/locust/stats.py#L221
What is not trivial is to do it the locust way for me (using annotations or any means to make it configurable)
So if someone have more experience in that, it could be good to have some suggestions.
Possible options I see:
What could be filtered out from aggregation are then obviously the following 2 options:
The text was updated successfully, but these errors were encountered: