-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installing 0.12.1 requires "pipenv lock --pre" #1116
Comments
(It's possible that this was also present in earlier versions: my last lock file that worked correctly indicated that it worked fine with 0.11.0). |
Thanks for reporting this! I'll try to issue a non pre-release version of geventhttoclient-wheels today. |
If we pinned the version to the prerelease one, would that solve the problem? |
I’m not sure: I think maybe Pipenv would still complain.
|
I just tried installing geventhttpclient-wheels using pipenv:
Which failed because I didn't use the
Wouldn't that indicate that it would work if we pinned the version locust's setup.py? I haven't used pipenv much, and not sure how to test it. |
I pinned the version in master, and now |
I'm not sure this has fixed things. The version of gevent being specified for locust is 1.5a2. This is a pre-release version. When I |
Same, I get the same errors. @heyman Can you re-open this? |
That's unfortunate. I could issue a non pre-release version of the geventhttpclient-wheels package, though I'd prefer not to, since I think it'd be better to follow the same version number as the official geventhttpclient package. Gevent 1.5 fixes fixes a bug which would cause Locust's Web UI to crash on Python 3.8 (#1154), so I don't think we'd want to downgrade to gevent 1.4 (the latest non pre-release version). Therefore, I don't see a good fix for this at the moment, except from maybe documenting it. |
@heyman You reopened this, but say there is no good solution :) I guess we are stuck waiting for a new release on geventhttpclient? Or should we "solve" the ticket by just documenting it? |
@cyberw We currently also pin the gevent version to 1.5a2 (to fix a crash on Python 3.8 (#1154)) which also is a pre-release version, so just releasing a non pre-release version of geventhttpclient-wheels won't resolve it. I think we should wait with a fix until gevent 1.5 is released. Until then I think it's a good idea to leave this open so that it's more discoverable for people running into the issue. |
I encountered the same problem with locustio 0.4.5 version
The only way i was able to install properly with pipenv is to use :
Hope this helped someone trying to install with pipenv Also does locustio use |
This has affected me too, used workaround thanks @linhnvhicts |
@heyman Now that there is a gevent 1.5 release, I guess we could build a non-prerelease eventhttpclient-wheels version? |
@cyberw Yes, we could do that. Only problem is that the version numbers in our |
@linhnvhicts IMO using the pre-release flag is not a good solution, as it will cause ALL dependencies (not just You are better of adding a pinned version of
@farridav Having said all that... |
…d of fork, now that there is a new release (I can trigger new releases later on as well). Relates to #1116
…d of fork, now that there is a new release (I can trigger new releases later on as well). Relates to #1116
Fixed (a while back) |
The latest release of
locustio
cannot really be managed using pipenv. It includes a dependency ofgeventhttpclient-wheels
, which has only pre-release versions available.As such, it is not possible to generate a
Pipfile.lock
file without usingpipenv lock --pre
.Doing this will install pre-release versions of other packages, which is problematic. (In my case, it installed a 5.0dev version of coverage, which uses a different coverage file format).
The text was updated successfully, but these errors were encountered: