Remove scroll to zoom

locustio · Aug 30, 2024 · 30e1541 · 30e1541
1 parent aea9d63
commit 30e1541
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 18 deletions.
diff --git a/locust/webui/src/components/LineChart/LineChart.types.ts b/locust/webui/src/components/LineChart/LineChart.types.ts
@@ -18,7 +18,7 @@ export interface ILineChart<ChartType> {
 }
 
 export interface ILineChartZoomEvent {
-  batch?: { start: number; end: number }[];
+  batch?: { start: number; startValue: number; end: number }[];
 }
 
 export interface ILineChartMarkers {

diff --git a/locust/webui/src/components/LineChart/LineChart.utils.ts b/locust/webui/src/components/LineChart/LineChart.utils.ts
@@ -91,13 +91,6 @@ export const createOptions = <ChartType extends Pick<ICharts, 'time'>>({
   scatterplot,
 }: ILineChart<ChartType>) => ({
   title: { text: title },
-  dataZoom: [
-    {
-      type: 'inside',
-      start: 0,
-      end: 100,
-    },
-  ],
   tooltip: {
     trigger: 'axis',
     formatter: (params?: ILineChartTooltipFormatterParams[] | null) => {
@@ -138,11 +131,11 @@ export const createOptions = <ChartType extends Pick<ICharts, 'time'>>({
     right: 10,
     feature: {
       dataZoom: {
-        show: true,
         title: {
           zoom: 'Zoom Select',
           back: 'Zoom Reset',
         },
+        yAxisIndex: false,
       },
       saveAsImage: {
         name: title.replace(/\s+/g, '_').toLowerCase() + '_' + new Date().getTime() / 1000,
@@ -176,21 +169,14 @@ export const onChartZoom = (chart: ECharts) => (datazoom: unknown) => {
     return;
   }
 
-  const [{ start, end }] = batch;
-  const isZoomed = start > 0 && end < 100;
+  const [{ start, startValue, end }] = batch;
+  const isZoomed = (start > 0 && end <= 100) || startValue > 0;
 
   chart.setOption({
     dataZoom: [
-      {
-        type: 'inside',
-        start,
-        end,
-      },
       {
         type: 'slider',
         show: isZoomed,
-        start,
-        end,
       },
     ],
   });