Fix repetition of fields in download URLs #3627
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #3626 Update `generateDownloadUrl` method to prevent duplicate fields in download URL. * **Prevent duplicate fields** - Use `params.set` instead of `params.append` for `versionStatus` and `isRevocation` fields. - Add checks to ensure `versionStatus` and `isRevocation` fields are not already set before setting them. * **General improvements** - Replace `params.append` with `params.set` for all fields in `downloadParameters.toUrlSearchParams()`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/loculus-project/loculus/issues/3626?shareId=XXXX-XXXX-XXXX-XXXX).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3626
Update
generateDownloadUrlmethod to prevent duplicate fields in download URL.Prevent duplicate fields
params.setinstead ofparams.appendforversionStatusandisRevocationfields.versionStatusandisRevocationfields are not already set before setting them.General improvements
params.appendwithparams.setfor all fields indownloadParameters.toUrlSearchParams().For more details, open the Copilot Workspace session.