-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Allow disabling data use terms #3468
base: main
Are you sure you want to change the base?
Conversation
As was discussed earlier, here are the code places marked where I think changes will be introduced to implement this feature. @corneliusroemer you wanted to have a look first. Putting this on hold till then. |
Would the backend not need any changes? |
That wasn't in the ticket I think. But maybe that was a mistake? I remember that we talked about that too actually. I'd be curious to look into how to do that |
My guess (maybe wrong) of what would happen if you made the changes annotated would be:
|
We need to do some changes so that (1) the backend accepts submissions that don't provide a data use term and (2) don't expose it in get-released-data. But if it make things easier, it could write "open" into the database. |
Ah, makes sense |
that should cover it. |
(I actually don't like huge gaps between the submit button and everything else!) |
perfect! 😄 |
These tests failed:
That is because the DUT UI elements are involved. But the tests will work again if the DUTs are enabled again in the values.yaml. It's unfortunate that our testing setup/the feature being for the whole instance doesn't allow us to test this better (or am I missing something @fengelniederhammer ) Next I'd add some more component tests and backend unit tests. |
e2e test failure is expected, we have to re-enable DUT before merging. (obv. the e2e tests should then be green). I'm leaving it set to 'false' so people can check the preview. |
open: https://#TODO-MVP/open | ||
restricted: https://#TODO-MVP/restricted | ||
dataUseTerms: | ||
enabled: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enabled: false | |
enabled: true |
BREAKING
values.yaml
changes (see below)resolves #3127
preview URL: https://disable-dut.loculus.org
Summary
This PR makes it possible to disable data use terms (DUT) for the whole Loculus instance with a switch in the
values.yaml
. This disables DUT-related features and components in various places in the front- and backend (outline below). In the database, all submissions are treated asOPEN
.The new config setting is
dataUseTerms.enabled
(boolean). It is currently required. (which is breaking because you need to add it and set it to either true or false).Furthermore,
dataUseTermsUrls
have been moved todataUseTerms.urls
(breaking).Full config example:
Frontend changes:
Backend changes:
submit
endpointget-released-data
endpoint.Testing
Screenshot
The submission dialog without the DUT elements:
The download dialog without the DUT elements:
The API docs don't mention the DUT anmore:
New docs page:
PR Checklist
Discussion about config structure: https://loculus.slack.com/archives/C05G172HL6L/p1738166112981629