chore: exclude flowbite-react due to issue #1545
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaoran-chen
reviewed
Apr 2, 2024
| @@ -16,6 +16,7 @@ updates: | |||
| exclude-patterns: | |||
| - "@mui/material" | |||
| - change-case | |||
| - flowbite-react # Due to https://github.com/themesberg/flowbite-react/issues/1343 | |||
There was a problem hiding this comment.
This is in order to enable #1543, right? Then, I think that we can just ask dependabot to ignore the dependency for now using @dependabot ignore <dependency name> minor version
There was a problem hiding this comment.
Ah, I see you already did, hmm.
There was a problem hiding this comment.
But we only want to ignore 0.7.8 - not higher versions. The disadvantage of your solution is that it won't tell us if 0.7.9 comes around - but excluding here would still mean dependabot opens prs when 0.7.9 comes out.
There was a problem hiding this comment.
Oh, it works with patch as well, undocumented but it works...
auto-merge was automatically disabled
April 2, 2024 14:25
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flowbite react >0.7.5 fails for us, so exempt it from dependabot updates
See themesberg/flowbite-react#1343