adding file upload #423
Merged
adding file upload #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kaplanelad LGTM! Thanks for your hard work as well! |
|
@kaplanelad Should we include documentation for the storage features and detail each StorageBuilder setup from the objectstore crate? The configuration aspect could be perplexing for some developers, given that the object_storage configuration is not located within the config/*.yaml files but in src/app.rs. 🤔 |
|
@yinho999 yes sure, |
|
@yinho999, I've included a documentation section. Could you please review it and share your feedback? |
Totally detailed about the feature. LGTM!👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am currently integrating file upload support into the framework. This enhancement incorporates strategic implementations inspired by the [Ruby Active Storage](https://guides.rubyonrails.org/active_storage_overview.html:
Out-of-the-box strategies:
Single: Designed for working exclusively with a single storage.
Mirror: Enables data mirroring across multiple stores, ensuring redundancy during file downloads.
Backup: Facilitates file backup across multiple storage locations.
Each strategy is implemented as a trait, empowering users to create their own custom strategies based on their specific needs.