Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SeaORM v1.0.0-rc.1 #420

Merged
merged 6 commits into from
Feb 8, 2024
Merged

SeaORM v1.0.0-rc.1 #420

merged 6 commits into from
Feb 8, 2024

Conversation

billy1624
Copy link
Contributor

@billy1624 billy1624 commented Feb 6, 2024

@kaplanelad kaplanelad marked this pull request as ready for review February 8, 2024 07:35
@@ -40,5 +40,5 @@ required-features = []
[dev-dependencies]
serial_test = "2.0.0"
rstest = "0.18.2"
loco-rs = { version = "0.2.3", features = ["testing"] }
loco-rs = { version = "*", path = "../../", features = ["testing"] }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When a user initializes a new project using our CLI, the starters are downloaded. However, when you point to path all starters may break. This it why we set a static version version.
This approach not only ensures stability for users' projects but also allows us to release new versions without immediate propagation to all users. It's worth noting that our deployment script automatically updates the specified version.

@@ -10,10 +10,10 @@ path = "src/lib.rs"

[dependencies]
async-std = { version = "1", features = ["attributes", "tokio1"] }
loco-rs = { version = "0.2.3" }
loco-rs = { version = "*", path = "../../../" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@@ -10,10 +10,10 @@ path = "src/lib.rs"

[dependencies]
async-std = { version = "1", features = ["attributes", "tokio1"] }
loco-rs = { version = "0.2.3" }
loco-rs = { version = "*", path = "../../../" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@@ -40,5 +40,5 @@ required-features = []
[dev-dependencies]
serial_test = "2.0.0"
rstest = "0.18.2"
loco-rs = { version = "0.2.3", features = ["testing"] }
loco-rs = { version = "*", path = "../../", features = ["testing"] }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@@ -9,7 +9,7 @@ edition = "2021"

[dependencies]

loco-rs = { version = "0.2.3", default-features = false, features = ["cli"] }
loco-rs = { version = "*", path = "../../", default-features = false, features = ["cli"] }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@@ -28,7 +28,7 @@ required-features = []
[dev-dependencies]
serial_test = "*"
rstest = "*"
loco-rs = { version = "0.2.3", default-features = false, features = [
loco-rs = { version = "*", path = "../../", default-features = false, features = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@kaplanelad
Copy link
Contributor

@billy1624 i'll merge and do the fixes

@kaplanelad kaplanelad merged commit e485624 into loco-rs:master Feb 8, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants