Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace API polling with db websocket sub #60

Merged
merged 10 commits into from
Sep 8, 2024
Merged

Conversation

0xernesto
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Sep 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
locker-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 8, 2024 8:42pm

Copy link
Contributor

@marvinmarnold marvinmarnold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xernesto I just tried to run this locally, connected to my personal Supabase, but new txs aren't being displayed via realtime. I turned off RLS. I also tried on the vercel preview link, but same problem.

Is this working in staging for you or is it not supposed to be now?

src/app/home/page.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@marvinmarnold marvinmarnold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xernesto I ended up doing a major rework of this. It did rely on open permissions and the data fetching was pretty hard for me to follow. I did also encounter issues getting RLS to play nice with Clerk but this thread was very helpful: supabase/supabase-js#553 (comment)

I'll do a bit more testing in staging and then will merge this soon. Thanks for all the help.

@marvinmarnold marvinmarnold merged commit 95bb637 into main Sep 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants