Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes broken tests in CI due ruby version and minor improvements #51

Merged
merged 7 commits into from
Oct 18, 2021
Merged

Fixes broken tests in CI due ruby version and minor improvements #51

merged 7 commits into from
Oct 18, 2021

Conversation

VictorSNA
Copy link
Contributor

Description

Fix tests that are broken in CI due ruby version by removing freeze from literal string.
Also, added linter step to CI, ignored .gems/ folder, updated build badge to point to github actions and removed duplicated bundle install.

Type of branch

Hotfix

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Running in forked repo CI.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@VictorSNA VictorSNA requested a review from TecnoSigma October 18, 2021 19:13
@VictorSNA VictorSNA self-assigned this Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants