Add a hash of hash response to Heartcheck #33
Conversation
|
Hello, @LuccaRosa! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information. |
LuccaRosa
force-pushed
the
add-hash-return
branch
from
0f33690 to
a52761d
Compare
Add a hash of hash response to Heartcheck
LuccaRosa
force-pushed
the
add-hash-return
branch
from
a52761d to
534f6b2
Compare
There was a problem hiding this comment.
@LuccaRosa I think it is missing to comment about this new configuration on README and mention this change on CHANGELOG
LuccaRosa
force-pushed
the
add-hash-return
branch
2 times, most recently
from
89f4555 to
b8dbb74
Compare
LuccaRosa
force-pushed
the
add-hash-return
branch
from
b8dbb74 to
5cac1b2
Compare
LuccaRosa
force-pushed
the
add-hash-return
branch
from
5cac1b2 to
8fd2e43
Compare
|
Salve galera, podemos mergear esse PR? Acredito que ele vai possibilitar algumas customizações legais que a gente pode querer fazer aqui na empresa :) |
|
SourceLevel has finished reviewing this Pull Request and has found:
|
This feature allows the user to choose between a JSON response with hashes
{ "Some Check": { "status": "ok", "time": 123.45}}and with an array[{"Some check": { "status": "ok"}, "time": 123.45}]using the boolean argumenthash_responseat the setup.