Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update heartcheck-cache version #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rogesson
Copy link

@rogesson rogesson commented Feb 8, 2021

update heartcheck-cache version

@sourcelevel-bot
Copy link

Hello, @rogesson! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

@@ -2,6 +2,6 @@
module Heartcheck
# gem version
module Cache
VERSION = '2.0.0'
VERSION = '3.0.0'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Freeze mutable objects assigned to constants.

@@ -17,7 +17,7 @@ Gem::Specification.new do |spec|
spec.test_files = spec.files.grep(/^spec\//)
spec.require_paths = ['lib']

spec.required_ruby_version = '>= 2.3'
spec.required_ruby_version = '>= 3.0'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

required_ruby_version (3.0, declared in heartcheck-redis.gemspec) and TargetRubyVersion (2.4, which may be specified in .rubocop.yml) should be equal.

@@ -1,3 +1,7 @@
## [3.0.0] - 2021-02-08
## Changed
- Add support for ruby 3.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect list-item indent: add 2 spaces

@@ -1,3 +1,7 @@
## [3.0.0] - 2021-02-08

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found reference to undefined definition

@@ -1,3 +1,7 @@
## [3.0.0] - 2021-02-08

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the trailing [] on reference links

@sourcelevel-bot
Copy link

SourceLevel has finished reviewing this Pull Request and has found:

  • 5 possible new issues (including those that may have been commented here).
  • 3 fixed issues! 🎉

See more details about this review.

NarayanAdithya added a commit to NarayanAdithya/heartcheck-cache that referenced this pull request Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant