Support concurrent application instances/checks #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fernandoalmeida I will merge it to fix our monitoring. We can fix the problem in build for ruby193 after |
NarayanAdithya
added a commit
to NarayanAdithya/heartcheck-cache
that referenced
this pull request
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Generally, we have many instances of the same application (for load balancing) and sometimes different applications sharing a single Memcache data source.
In these scenarios, the checks randomly fail, depending on the order of
get,set,deletecompeting between all instances.Proposal
Use unique keys when accessing Memcache.