Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pods/exec permissions to the service account role #122

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

dfangl
Copy link
Member

@dfangl dfangl commented Jun 7, 2024

Motivation

With the effort to improve kubernetes support, we try to use kubernetes pods to run database containers.

However, our implementations of these databases requires to exec into the pod / container.

Changes

  • Add permission to exec in a pod to the service account role

TODO

  • A still open question for these database services is how to map them to the service port range, and how to ensure the returned address (by LS) is reachable from outside (or also inside) the cluster. This is independently of this PR though.

@alexrashed alexrashed added the type: enhancement Improvement to usability or performance label Jun 10, 2024
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is looking good, and the additional permissions for the service account are reasonable! Thanks for the contribution! 🥳

@alexrashed alexrashed merged commit f517c9c into main Jun 10, 2024
2 checks passed
@alexrashed alexrashed deleted the kubernetes-database-abstraction branch June 10, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement to usability or performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants