Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add devcontainers-extra versions from the collections index for installsAfter #8

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

frankpengau
Copy link
Contributor

@frankpengau frankpengau commented Nov 21, 2024

Adding devcontainers-extra versions for installsAfter.

  • "ghcr.io/devcontainers-extra/features/aws-cdk",
  • "ghcr.io/devcontainers-extra/features/pulumi",

Ref:

@frankpengau
Copy link
Contributor Author

@lakkeger Please review at your earliest convenience. Many Thanks

@frankpengau frankpengau changed the title Add devcontainers-extra versions from the official index for installsAfter Add devcontainers-extra versions from the collections index for installsAfter Nov 21, 2024
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @frankpengau! Thanks a lot for your contribution!
Could you give us a bit more context on the change you are suggesting?
Should these versions be added in addition or should they be replace the "contrib" features?

@alexrashed alexrashed added the enhancement New feature or request label Nov 27, 2024
@frankpengau
Copy link
Contributor Author

I was adding them in addition to the existing ones, just in case if anyone is still pulling in the old ones.

But happy for you to replace them and release a new version and just advise others to stay on older version if they want to use previous devcontainers-contrib ones instead.

@frankpengau
Copy link
Contributor Author

@alexrashed Any updates on this one?

Happy to either change it and release as new version or merge it? If not needed, happy to just close it off and I'll just fork it?

@alexrashed alexrashed requested a review from pinzon January 7, 2025 12:34
@alexrashed
Copy link
Member

Thanks a lot, @frankpengau! I think we should just remove the "old" / deprecated contrib extra.
Afterwards we can do some basic testing, merge the PR, and release a new version :)

Copy link
Member

@pinzon pinzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution. I'll trigger a release later.

@pinzon pinzon merged commit c402cbf into localstack:main Jan 8, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants