Refactor: Update eventFilter in MainWindow to set default box display… #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… style This commit updates the eventFilter method in the MainWindow class to set the default box display style. The previous implementation used the fetch_data function to retrieve the box display style from the "scoresight.json" file, but it did not handle cases where the retrieved value was not an integer. This commit introduces a check to ensure that the retrieved value is an integer and sets it as the current index of the comboBox_boxDisplayStyle. If the retrieved value is not an integer, the default index of 3 is used instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… style
This commit updates the eventFilter method in the MainWindow class to set the default box display style. The previous implementation used the fetch_data function to retrieve the box display style from the "scoresight.json" file, but it did not handle cases where the retrieved value was not an integer. This commit introduces a check to ensure that the retrieved value is an integer and sets it as the current index of the comboBox_boxDisplayStyle. If the retrieved value is not an integer, the default index of 3 is used instead.