Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Update screen capture sources to include get() method #37

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

royshil
Copy link
Contributor

@royshil royshil commented Sep 25, 2024

  • Added a get() method to the ScreenCaptureBase class and its subclasses (ScreenCaptureDummy, ScreenCaptureMacOS, and ScreenCaptureWindows) to retrieve the frame width and height.
  • The get() method returns the frame width and height using the cv2.CAP_PROP_FRAME_WIDTH and cv2.CAP_PROP_FRAME_HEIGHT properties respectively.
  • This update allows for easier access to the frame dimensions when working with screen capture sources.

- Added a `get()` method to the `ScreenCaptureBase` class and its subclasses (`ScreenCaptureDummy`, `ScreenCaptureMacOS`, and `ScreenCaptureWindows`) to retrieve the frame width and height.
- The `get()` method returns the frame width and height using the `cv2.CAP_PROP_FRAME_WIDTH` and `cv2.CAP_PROP_FRAME_HEIGHT` properties respectively.
- This update allows for easier access to the frame dimensions when working with screen capture sources.
@royshil royshil merged commit 84d950a into main Sep 25, 2024
5 checks passed
@royshil royshil deleted the roy.fix_screen_capture_dimensions_get branch September 25, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant