Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add depth estimation model #366

Merged
merged 14 commits into from
Jul 4, 2023
Merged

Add depth estimation model #366

merged 14 commits into from
Jul 4, 2023

Conversation

royshil
Copy link
Collaborator

@royshil royshil commented Jul 2, 2023

Adding the TCMonoDepth model for depth estimation along with the "blur focus point" setting to simluate depth of field

@royshil royshil added this to the v1.0.4 milestone Jul 2, 2023
@royshil royshil requested a review from umireon July 2, 2023 19:02
@royshil royshil self-assigned this Jul 2, 2023
@umireon
Copy link
Member

umireon commented Jul 2, 2023

@royshil Please format

@royshil
Copy link
Collaborator Author

royshil commented Jul 3, 2023

@umireon this is ready for review

Copy link
Member

@umireon umireon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work!

@royshil royshil requested a review from umireon July 3, 2023 18:47
@royshil
Copy link
Collaborator Author

royshil commented Jul 3, 2023

@umireon i've fixed the blur to be a "Focal blur", now it works as expected
Can you please check on your end?

Copy link
Member

@umireon umireon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the indentation in effect files.
Tabs and spaces are mixed but we used only tabs so far.

@umireon
Copy link
Member

umireon commented Jul 4, 2023

And it does not work with the following error

error: effect_setval_inline: invalid param

@royshil royshil requested a review from umireon July 4, 2023 02:19
@royshil
Copy link
Collaborator Author

royshil commented Jul 4, 2023

@umireon i've fixed the problems, thank you for pointing it out!

Copy link
Member

@umireon umireon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@umireon
Copy link
Member

umireon commented Jul 4, 2023

We can call v1.1.0 for this feature?

@royshil royshil merged commit 04ba710 into main Jul 4, 2023
@royshil royshil deleted the roy.add_depth_estimation_model branch July 4, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants