-
-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add depth estimation model #366
Conversation
@royshil Please format |
@umireon this is ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work!
@umireon i've fixed the blur to be a "Focal blur", now it works as expected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the indentation in effect files.
Tabs and spaces are mixed but we used only tabs so far.
And it does not work with the following error
|
@umireon i've fixed the problems, thank you for pointing it out! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
We can call v1.1.0 for this feature? |
Adding the TCMonoDepth model for depth estimation along with the "blur focus point" setting to simluate depth of field