We need to update the OBS dependency to 29. #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I cannot install OBS 28 on my machine because all the OBS distribution is already OBS 29. |
|
I cannot spare any more time to investigate to make this plugin buildable with OBS 28 binaries. |
|
We can still provide an option that OBS 28 users can use older versions of this plugin. |
royshil
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I finally finally concluded that we have to use OBS 29 with the new build system and Qt6.
It is nearly impossible to build both with Qt6 and with OBS 28.
See #359
I think our plugin may work with OBS 28 when the build dependency is OBS 29.