-
-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fix: fix fallback behavior of default mode in AgentRuntime #4813
Conversation
@hezhijie0327 is attempting to deploy a commit to the LobeChat Community Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for raising your pull request and contributing to our Community |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4813 +/- ##
=========================================
Coverage 91.53% 91.53%
=========================================
Files 538 538
Lines 37803 37803
Branches 3651 2478 -1173
=========================================
Hits 34603 34603
Misses 3200 3200
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
❤️ Great PR @hezhijie0327 ❤️ The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world. |
### [Version 1.34.3](v1.34.2...v1.34.3) <sup>Released on **2024-11-27**</sup> #### 🐛 Bug Fixes - **misc**: Fix fallback behavior of default mode in AgentRuntime. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's fixed * **misc**: Fix fallback behavior of default mode in AgentRuntime, closes [#4813](#4813) ([e7cb62e](e7cb62e)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>
🎉 This PR is included in version 1.34.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
### [Version 1.76.2](v1.76.1...v1.76.2) <sup>Released on **2024-11-28**</sup> #### 🐛 Bug Fixes - **misc**: Fix fallback behavior of default mode in AgentRuntime. #### 💄 Styles - **misc**: Add switch portal thread. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's fixed * **misc**: Fix fallback behavior of default mode in AgentRuntime, closes [lobehub#4813](https://github.com/bentwnghk/lobe-chat/issues/4813) ([e7cb62e](e7cb62e)) #### Styles * **misc**: Add switch portal thread, closes [lobehub#4819](https://github.com/bentwnghk/lobe-chat/issues/4819) ([8dbf3ce](8dbf3ce)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>
💻 变更类型 | Change Type
🔀 变更说明 | Description of Change
触发原因:
当时 Fallback 判定写的有问题,不应该用 APIKey 值是否存在作为判定依据,导致只要模型的 APIKey 环境变量为空,就走 OpenAI。也反向印证了昨天 Qwen 行为在设置
QWEN_API_KEY
后就正常改进方法:
改为判定
*_API_KEY
是否在 llmConfig 中声明close #4809
📝 补充信息 | Additional Information
测试场景:
OPENAI_PROXY_URL
https://proxy.example.org/v1
ANTHROPIC_API_KEY