Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some migrations #191

Merged
merged 2 commits into from
Nov 10, 2024
Merged

fix some migrations #191

merged 2 commits into from
Nov 10, 2024

Conversation

dinmukhamedm
Copy link
Member

@dinmukhamedm dinmukhamedm commented Nov 10, 2024

Remove some duplication in migration files that had arised from merge conflicts manual resolution


Important

Fixes duplication and incorrect foreign key names in migration files to resolve merge conflict issues.

  • Migrations:
    • Remove duplicate ALTER TABLE statement in 0004_worthless_kitty_pryde.sql.
    • Correct foreign key name from labelling_queue_data_queue_id_fkey to labeling_queue_items_queue_id_fkey in 0002_snapshot.json and 0003_snapshot.json.

This description was created by Ellipsis for 7f8acd4. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 0b1ed8b in 34 seconds

More details
  • Looked at 45 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_LFArSCK1ZoG4xyIM


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

"labelling_queue_data_queue_id_fkey": {
"name": "labelling_queue_data_queue_id_fkey",
"labelling_queue_items_queue_id_fkey": {
"name": "llabelling_queue_items_queue_id_fkey",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in foreign key name: llabelling_queue_items_queue_id_fkey should be labeling_queue_items_queue_id_fkey. This typo is also present in 0002_snapshot.json.

Suggested change
"name": "llabelling_queue_items_queue_id_fkey",
"name": "labeling_queue_items_queue_id_fkey",

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Incremental review on 7f8acd4 in 32 seconds

More details
  • Looked at 27 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_tv9NZFRAa1F97ivd


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@@ -757,8 +757,8 @@
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change here is incorrect. The foreign key name should be labeling_queue_items_queue_id_fkey instead of labelling_queue_items_queue_id_fkey.

@dinmukhamedm dinmukhamedm merged commit e966334 into dev Nov 10, 2024
1 check passed
@dinmukhamedm dinmukhamedm deleted the fix/migrations branch November 10, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant