-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix some migrations #191
fix some migrations #191
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to 0b1ed8b in 34 seconds
More details
- Looked at
45
lines of code in3
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_LFArSCK1ZoG4xyIM
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
"labelling_queue_data_queue_id_fkey": { | ||
"name": "labelling_queue_data_queue_id_fkey", | ||
"labelling_queue_items_queue_id_fkey": { | ||
"name": "llabelling_queue_items_queue_id_fkey", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in foreign key name: llabelling_queue_items_queue_id_fkey
should be labeling_queue_items_queue_id_fkey
. This typo is also present in 0002_snapshot.json
.
"name": "llabelling_queue_items_queue_id_fkey", | |
"name": "labeling_queue_items_queue_id_fkey", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Incremental review on 7f8acd4 in 32 seconds
More details
- Looked at
27
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_tv9NZFRAa1F97ivd
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
@@ -757,8 +757,8 @@ | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change here is incorrect. The foreign key name should be labeling_queue_items_queue_id_fkey
instead of labelling_queue_items_queue_id_fkey
.
Remove some duplication in migration files that had arised from merge conflicts manual resolution
Important
Fixes duplication and incorrect foreign key names in migration files to resolve merge conflict issues.
ALTER TABLE
statement in0004_worthless_kitty_pryde.sql
.labelling_queue_data_queue_id_fkey
tolabeling_queue_items_queue_id_fkey
in0002_snapshot.json
and0003_snapshot.json
.This description was created by for 7f8acd4. It will automatically update as commits are pushed.