Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't join spans on count traces query #182

Merged
merged 1 commit into from
Nov 9, 2024
Merged

Conversation

dinmukhamedm
Copy link
Member

@dinmukhamedm dinmukhamedm commented Nov 9, 2024

Important

Simplify count_traces query in trace.rs by removing span joins and adjust SessionsTable UI in sessions-table.tsx.

  • Database Query:
    • Modify count_traces in trace.rs to avoid joining spans, simplifying the query.
    • Add add_date_range_to_query call in count_traces for date filtering.
  • Frontend:
    • Set column sizes in SessionsTable in sessions-table.tsx.
    • Rename headers in SessionsTable for clarity (e.g., 'Token count' to 'Total tokens').
  • Misc:
    • Add comment in spans.rs for LiteLLM auto-instrumentation handling.

This description was created by Ellipsis for c4f95ad. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to c4f95ad in 45 seconds

More details
  • Looked at 136 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. frontend/components/traces/sessions-table.tsx:157
  • Draft comment:
    The addition of size property to columns is consistent and looks good.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The size property is added to multiple columns in the SessionsTable component. This is a new addition and seems consistent across all columns, so no issues here.

Workflow ID: wflow_UfhZdyKGEYEfKj6V


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@dinmukhamedm dinmukhamedm merged commit cd97631 into dev Nov 9, 2024
1 check passed
@dinmukhamedm dinmukhamedm deleted the fix/trace-count-query branch November 9, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant