Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced all Loader to Loader2 #133

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Conversation

lucky29-git
Copy link
Contributor

@lucky29-git lucky29-git commented Nov 1, 2024

This PR solves issue #128

Important

Replaces Loader with Loader2 in loading indicators across multiple UI components for a consistent visual appearance.

  • UI Components:
    • Replaces Loader with Loader2 in loading indicators across various components such as dataset-panel.tsx, dataset-upload.tsx, and delete-datapoints-dialog.tsx.
    • Affects components in pipeline, projects, settings, traces, and workspace directories.
  • Behavior:
    • Visual change in loading indicators, using Loader2 for a consistent look.
  • Misc:
    • Updates import statements to remove Loader and include Loader2 from lucide-react.

This description was created by Ellipsis for b5c2a4c. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to b5c2a4c in 38 seconds

More details
  • Looked at 654 lines of code in 29 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_UiChXF3DHG7bTN01


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Member

@dinmukhamedm dinmukhamedm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dinmukhamedm dinmukhamedm merged commit c9461ad into lmnr-ai:dev Nov 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants