redirect to onboarding if no workspaces yet #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 3be7fb5 in 32 seconds
More details
- Looked at
24lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_UWm9ecWpnuo98Z3U
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -20,6 +21,11 @@ export default function Projects({ isWorkspaceEnabled }: ProjectsProps) { | |||
| swrFetcher | |||
| ); | |||
|
|
|||
| const router = useRouter(); | |||
| if (data !== undefined && data.length === 0) { | |||
There was a problem hiding this comment.
Consider checking for isLoading before redirecting to ensure data is fully loaded before making a decision.
Suggested change
| if (data !== undefined && data.length === 0) { | |
| if (!isLoading && data !== undefined && data.length === 0) { |
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 33a3965 in 6 seconds
More details
- Looked at
15lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. frontend/components/projects/projects.tsx:25
- Draft comment:
Consider checking ifdatais not null or undefined before checking its length to avoid potential runtime errors. - Reason this comment was not posted:
Confidence changes required:50%
The use ofrouter.replaceis appropriate for redirecting without adding a new entry to the history stack. However, the condition should ensure thatdatais not null or undefined before checking its length.
Workflow ID: wflow_NoE4LS1hDHuiQWaG
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, onboarding flow breaks for people (e.g. signed in, then signed in from a different browser) and it is extremely difficult to figure out how to get started. This change redirects to onboarding if the user has 0 workspaces.
Important
Redirects to onboarding in
Projectscomponent if no workspaces are found usinguseRouter./onboardingifdatais defined and empty inProjectscomponent.useRouterfromnext/navigationto handle redirection.This description was created by
for 33a3965. It will automatically update as commits are pushed.