Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix number of valence electrons for Pd #92

Merged
merged 2 commits into from
Nov 28, 2022
Merged

Fix number of valence electrons for Pd #92

merged 2 commits into from
Nov 28, 2022

Conversation

lmmentel
Copy link
Owner

closes #91

mendeleev/econf.py Outdated Show resolved Hide resolved
@lmmentel lmmentel requested a review from kalvdans November 28, 2022 14:10
@@ -147,20 +163,16 @@

self._conf = OrderedDict(list(core.items()) + list(valence.items()))

def get_largest_core(self):
def get_largest_core(self) -> Tuple:

Check notice

Code scanning / CodeQL

Explicit returns mixed with implicit (fall through) returns

Mixing implicit and explicit returns may indicate an error as implicit returns always return None.
return ElectronicConfiguration(valence)

def sort(self, inplace=True):
def sort(self, inplace: bool = True):

Check notice

Code scanning / CodeQL

Explicit returns mixed with implicit (fall through) returns

Mixing implicit and explicit returns may indicate an error as implicit returns always return None.
Copy link
Collaborator

@kalvdans kalvdans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Great with documentation and tests!

@lmmentel lmmentel merged commit e98f28e into master Nov 28, 2022
@lmmentel lmmentel deleted the fix/nvalence branch November 28, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Valance electron of Pd
2 participants