Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNT] Improve performance of fetch_electronegativity #198

Merged
merged 3 commits into from
Nov 4, 2024
Merged

[MNT] Improve performance of fetch_electronegativity #198

merged 3 commits into from
Nov 4, 2024

Conversation

lmmentel
Copy link
Owner

@lmmentel lmmentel commented Oct 20, 2024 •
edited
Loading

Proposed Changes

  • refactored fetch_electronegativities and fetch_neutral_data to improve performance
  • switched math to numpy where possible in electronegativities.py module
  • deprecated fetch.get_zeff, fetch.add_plot_columns and fetch.get_app_data as they are obsolete and that functionality exists elsewhere

@lmmentel lmmentel enabled auto-merge (squash) November 4, 2024 20:03
@lmmentel lmmentel self-assigned this Nov 4, 2024
@lmmentel lmmentel disabled auto-merge November 4, 2024 20:04
@lmmentel lmmentel merged commit 5de9239 into master Nov 4, 2024
20 checks passed
@lmmentel lmmentel deleted the mnt/speed-up-fetch branch November 4, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lmmentel lmmentel

Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lmmentel