Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve element not found #142

Merged
merged 2 commits into from
Mar 31, 2024
Merged

Improve element not found #142

merged 2 commits into from
Mar 31, 2024

Conversation

Vi-L
Copy link
Contributor

@Vi-L Vi-L commented Mar 30, 2024

Closes #141

@lmmentel
Copy link
Owner

lmmentel commented Mar 30, 2024 •
edited
Loading

Thanks for the fix. I enabled CI and noticed that there are a few formatting issues, would you mind running ruff or pre-commit on the changed files?

On a more general note, what do you think about making the comparison case insensitive?

@lmmentel lmmentel merged commit 21c4596 into lmmentel:master Mar 31, 2024
20 checks passed
@lmmentel
Copy link
Owner

Thanks @Vi-L 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalvdans kalvdans kalvdans approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confusing error message when element not found
3 participants
@Vi-L @lmmentel @kalvdans