Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update abundance for 126Te isotope #123

Merged
merged 1 commit into from
Jul 9, 2023
Merged

Update abundance for 126Te isotope #123

merged 1 commit into from
Jul 9, 2023

Conversation

lmmentel
Copy link
Owner

@lmmentel lmmentel commented Jul 8, 2023

Change the source for isotopic abundancies from nubase 3 for nubase 4. The only change between the files is the abundance for 126Te.

fixes #122

@lmmentel lmmentel added data Data update bugfix labels Jul 8, 2023
@lmmentel lmmentel marked this pull request as ready for review July 8, 2023 16:01
@lmmentel lmmentel requested a review from kalvdans July 8, 2023 19:10
Copy link
Collaborator

@kalvdans kalvdans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the git hack from #46 (comment) I was able to do a proper diff:

diff --git a/docs/source/references.bib b/docs/source/references.bib
index c0c3779..2a2b732 100644
--- a/docs/source/references.bib
+++ b/docs/source/references.bib
@@ -809,7 +809,7 @@
   author    = {F.G. Kondev and M. Wang and W.J. Huang and S. Naimi and G. Audi},
   title     = {The {NUBASE}2020 evaluation of nuclear physics properties {\ast}},
   journal   = {Chinese Physics C},
-  note      = {Data file: https://www-nds.iaea.org/amdc/ame2020/nubase_3.mas20.txt}
+  note      = {Data file: https://www.anl.gov/sites/www/files/2022-11/nubase_4.mas20.txt}
 }
 @article{IUPAC-InChI,
   author  = {Heller, Stephen R. and McNaught, Alan and Pletnev, Igor and Stein, Stephen and Tchekhovskoi, Dmitrii},
diff --git a/mendeleev/elements.db b/mendeleev/elements.db
index 6c5188f..030e2a0 100644
--- a/mendeleev/elements.db
+++ b/mendeleev/elements.db
@@ -9384,7 +9384,7 @@ INSERT INTO isotopes VALUES(1543,48,125.92243028999999409,NULL,126,2.47299999999
 INSERT INTO isotopes VALUES(1544,49,125.91646820200000433,NULL,126,4.500000000000000114e-06,1,1.5300000000000000266,'s','3',1.3426666666666664529,0.46999999999999997335,'+',1974,0.0036666666666666665984,NULL,0.010000000000000000208,0.050000000000000002775);
 INSERT INTO isotopes VALUES(1545,50,125.90765895799999895,NULL,126,1.1473000000000000098e-05,1,229.99999999999999999,'ky','0',0.0,0.0,'+',1962,0.0,NULL,13.999999999999999999,0.0);
 INSERT INTO isotopes VALUES(1546,51,125.90725315800000317,NULL,126,3.4189000000000000802e-05,1,12.349999999999999644,'d','8',0.16000000000000000333,NULL,'-',1956,0.0087500000000000008326,NULL,0.059999999999999997779,NULL);
-INSERT INTO isotopes VALUES(1547,52,125.90331214399999737,8.8399999999999998578,126,1.452999999999999895e-06,0,NULL,NULL,'0',0.0,0.0,'+',1924,0.0,0.25,NULL,0.0);
+INSERT INTO isotopes VALUES(1547,52,125.90331214399999737,18.839999999999999857,126,1.452999999999999895e-06,0,NULL,NULL,'0',0.0,0.0,'+',1924,0.0,0.25,NULL,0.0);
 INSERT INTO isotopes VALUES(1548,53,125.90562420499999518,NULL,126,4.0550000000000001394e-06,1,12.929999999999999716,'d','2',0.71899999999999997246,NULL,'-',1938,0.0020000000000000000416,NULL,0.050000000000000002775,NULL);
 INSERT INTO isotopes VALUES(1549,54,125.90429742199999907,0.088999999999999995781,126,5.9999999999999999601e-09,0,NULL,NULL,'0',0.0,0.0,'+',1922,0.0,0.0030000000000000000624,NULL,0.0);
 INSERT INTO isotopes VALUES(1550,55,125.90944582100000558,NULL,126,1.1120000000000000259e-05,1,1.6399999999999999023,'m','1',0.77600000000000002309,-0.64000000000000001332,'+',1954,0.0040000000000000000832,NULL,0.020000000000000000416,0.029999999999999998889);

Looks good to me!

@lmmentel lmmentel merged commit 4b63dc1 into master Jul 9, 2023
@lmmentel lmmentel deleted the fix/abundance-126Te branch July 9, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix data Data update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Natural abundances for Te126 and Ta180 are incorrect
2 participants