Defer loading element data until attribute access #121
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's my quick attempt to reduce the overall import time by deferring the autoload of element data until one actually accesses the corresponding attribute from the
mendeleev
module, e.g.mendeleev.Li
. This seems to work pretty well in my limited testing. The only downside I can see is that the attribute names (H
,He
, etc.) won't show up in an autocomplete from an IDE. @lmmentel Let me know what you think of this approach.Fixes #118
Import timing
master
branch (python3.12):Import timing
current
branch (python3.12):On average this amounts to 7X speedup of import time.