Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove six dependency #120

Merged
merged 3 commits into from
Jun 28, 2023
Merged

Remove six dependency #120

merged 3 commits into from
Jun 28, 2023

Conversation

paulromano
Copy link
Collaborator

This PR removes the dependency on six, which shouldn't be needed since Python support is 3.8+. I've replaced six.string_types with str.

Also added one more little README fix -- the LGTM badges were broken so I removed them.

@lmmentel
Copy link
Owner

Great! Could you run poetry lock locally after removing six to re-lock the dependencies and commit the poetry.lock file as well?

@paulromano
Copy link
Collaborator Author

Sure; just updated the poetry.lock file

lmmentel
lmmentel approved these changes Jun 28, 2023
View reviewed changes
Copy link
Owner

@lmmentel lmmentel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lmmentel lmmentel merged commit 9ad9713 into lmmentel:master Jun 28, 2023
@paulromano paulromano deleted the remove-six-dependency branch June 29, 2023 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmmentel lmmentel lmmentel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulromano @lmmentel