-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(lts-schedule): Introduce fork of the Node.js LTS schedule script #1792
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
c3d41c1
to
a215cbe
Compare
23f6587
to
b44fb02
Compare
a215cbe
to
9f8564b
Compare
b44fb02
to
729e664
Compare
* custom release schedule graph generator
729e664
to
3511321
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we add this to the workspaces in the main package.json?
[release-jira-board]: https://jira.almacareer.tech/projects/DS?selectedItem=com.atlassian.jira.jira-projects-plugin%3Arelease-page&status=released-unreleased | ||
[release-names-decision]: https://github.com/lmc-eu/spirit-design-system/blob/main/docs/decisions/007-release-names.md | ||
[release-schedule-static]: https://raw.githubusercontent.com/lmc-eu/spirit-design-system/refs/heads/main/static/release-schedule.svg | ||
[spirit-docs]: https://spirit.design | ||
[spirit-figma]: https://www.figma.com/design/w9Ca4hvkuYLshsrHu1bYwT/Spirit-UI-KIT?node-id=22776-26259&node-type=canvas&t=JIF1i6Yfp9rGUA35-0 | ||
[spirit-github-monorepo]: https://github.com/lmc-eu/spirit-design-system | ||
[spirit-jira-board]: https://jira.almacareer.tech/secure/RapidBoard.jspa?rapidView=366&projectKey=DS | ||
[spirit-lts-schedule]: https://github.com/lmc-eu/spirit-design-system/tree/main/packages/lts-schedule |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[spirit-lts-schedule]: https://github.com/lmc-eu/spirit-design-system/tree/main/packages/lts-schedule | |
[spirit-lts-schedule]: https://github.com/lmc-eu/spirit-design-system/tree/main/scripts/lts-schedule |
?
|
||
### Options | ||
|
||
- `-d`, `--data` - The path of the input JSON file. The JSON file should be of the same format as the [one in Node's LTS repo][node-lts-repo]. If this option is not provided, `lts` uses its own bundled JSON file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- `-d`, `--data` - The path of the input JSON file. The JSON file should be of the same format as the [one in Node's LTS repo][node-lts-repo]. If this option is not provided, `lts` uses its own bundled JSON file. | |
- `-d`, `--data` - The path of the input JSON file. The JSON file should be the same format as the [one in Node's LTS repo][node-lts-repo]. If this option is not provided, `lts` uses its own bundled JSON file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"of" or "in", I believe…
- `-g`, `--svg` - The location to write the SVG output file. Optional. | ||
- `-p`, `--png` - The location to write the PNG output file. Uses `svg2png` under the hood. Optional. | ||
- `-a`, `--animate` - Animate the bars of the graph on load. | ||
- `-m`, `--excludeMaster` - Exclude the `Master (unstable)` bar that is ever-present at the top of the graph. Optional. Defaults to false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- `-m`, `--excludeMaster` - Exclude the `Master (unstable)` bar that is ever-present at the top of the graph. Optional. Defaults to false | |
- `-m`, `--excludeMaster` - Exclude the `Master (unstable)` bar that is ever-present at the top of the graph. Optional. Defaults to false. |
- `-p`, `--png` - The location to write the PNG output file. Uses `svg2png` under the hood. Optional. | ||
- `-a`, `--animate` - Animate the bars of the graph on load. | ||
- `-m`, `--excludeMaster` - Exclude the `Master (unstable)` bar that is ever-present at the top of the graph. Optional. Defaults to false | ||
- `-n`, `--projectName` - Provide a project name for the graph which will be displayed on the left axis beside each version. Optional. Defaults to `Node.js` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- `-n`, `--projectName` - Provide a project name for the graph which will be displayed on the left axis beside each version. Optional. Defaults to `Node.js` | |
- `-n`, `--projectName` - Provide a project name for the graph, which will be displayed on the left axis beside each version. Optional. Defaults to `Node.js`. |
|
||
## 🙌 Contributing | ||
|
||
We're always looking for contributors to help us fix bugs, build new features, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we? :D
@@ -30,6 +30,8 @@ export default { | |||
'prettier-config', | |||
'stylelint-config', | |||
'typescript-config', | |||
// Use when affecting the scripts | |||
'scripts', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you use something else in the commit. Maybe use this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is too long 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is it broken here 🤔
Description
Additional context
#1790
Issue reference
https://jira.almacareer.tech/browse/DS-1552