Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(web-react): Introduce Toast component #DS-1113 #1329

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Feat(web-react): Introduce Toast component #DS-1113 #1329

merged 1 commit into from
Apr 8, 2024

Conversation

pavelklibani
Copy link
Contributor

  • solve #DS-1113

Description

Additional context

Issue reference

@pavelklibani pavelklibani self-assigned this Apr 3, 2024
@pavelklibani pavelklibani requested review from literat and a team as code owners April 3, 2024 10:12
@github-actions github-actions bot added the feature New feature or request label Apr 3, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 3, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit d96a737
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/6613c841130da10008f94024
😎 Deploy Preview https://deploy-preview-1329--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Apr 3, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit d96a737
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/6613c840a6c4e10008e595b6

@netlify Netlify
Copy link

netlify bot commented Apr 3, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit d96a737
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/6613c840dd2b260008469f6d
😎 Deploy Preview https://deploy-preview-1329--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Apr 3, 2024 •
edited
Loading

Coverage Status

coverage: 80.966% (+0.3%) from 80.646%
when pulling d96a737 on feat/DS-1113-toast-react
into 2c58272 on main.

@literat literat requested review from adamkudrna and crishpeen April 3, 2024 12:37
literat
literat requested changes Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work. Most of the code looks great and shiny. I have written a few suggestions but this is a really quality job.

Also, do not forget to add the Toast to the scripts/entrypoints where it is missing.

packages/web-react/src/components/Toast/README.md Outdated Show resolved Hide resolved
packages/web-react/src/components/Toast/README.md Show resolved Hide resolved
packages/web-react/src/components/Toast/Toast.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/Toast/ToastBar.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/Toast/__tests__/Toast.test.tsx Show resolved Hide resolved
packages/web-react/src/components/Toast/ToastBar.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/Toast/useToastStyleProps.ts Outdated Show resolved Hide resolved
packages/web-react/src/components/Toast/useToastStyleProps.ts Outdated Show resolved Hide resolved
@literat
Copy link
Collaborator

literat commented Apr 3, 2024

Screenshot 2024-04-03 at 15 13 56

Please, check if you accidentally dropped something. When I close the Toasts starting the one at the bottom, the Toasts above stay in place instead of going down.

@pavelklibani
Copy link
Contributor Author

Screenshot 2024-04-03 at 15 13 56

Please, check if you accidentally dropped something. When I close the Toasts starting the one at the bottom, the Toasts above stay in place instead of going down.

Yes, that was a problem with the transitions. It should be fixed now. Thank you for finding this bug!

literat
literat reviewed Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second run, double fun ;-)

packages/web-react/src/components/Toast/ToastBar.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/Toast/ToastBar.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/Toast/constants.ts Outdated Show resolved Hide resolved
@literat
Copy link
Collaborator

literat commented Apr 3, 2024

Screenshot 2024-04-03 at 15 13 56
Please, check if you accidentally dropped something. When I close the Toasts starting the one at the bottom, the Toasts above stay in place instead of going down.

Yes, that was a problem with the transitions. It should be fixed now. Thank you for finding this bug!

Great, now it is working just fine 👍

@pavelklibani pavelklibani force-pushed the feat/DS-1113-toast-react branch 3 times, most recently from 650e5f5 to be98561 Compare April 4, 2024 13:37
@pavelklibani pavelklibani requested a review from literat April 4, 2024 13:41
@pavelklibani pavelklibani force-pushed the feat/DS-1113-toast-react branch 2 times, most recently from 070864c to 2b6c524 Compare April 4, 2024 15:13
literat
literat reviewed Apr 5, 2024
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just caught my eye a one little optimization. But it is up to you.

packages/web-react/src/components/Toast/useToastStyleProps.ts Outdated Show resolved Hide resolved
packages/web-react/src/components/Toast/useToastStyleProps.ts Outdated Show resolved Hide resolved
packages/web-react/src/components/Toast/useToastStyleProps.ts Outdated Show resolved Hide resolved
@pavelklibani pavelklibani force-pushed the feat/DS-1113-toast-react branch from 2b6c524 to 71570d2 Compare April 8, 2024 10:34
@pavelklibani pavelklibani force-pushed the feat/DS-1113-toast-react branch from 71570d2 to d96a737 Compare April 8, 2024 10:34
@pavelklibani pavelklibani merged commit 94fa553 into main Apr 8, 2024
21 checks passed
@pavelklibani pavelklibani deleted the feat/DS-1113-toast-react branch April 8, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crishpeen crishpeen crishpeen left review comments

@literat literat literat approved these changes

@adamkudrna adamkudrna Awaiting requested review from adamkudrna

Assignees

@pavelklibani pavelklibani

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pavelklibani @coveralls @literat @crishpeen