Add rewards and penalties to random events #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Throws a "Can not find bacteria undefined" error, and returns null
|
This pull request introduces 2 alerts when merging cc77189 into a5f03d6 - view on LGTM.com new alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #95 .
As of now, I've only done a bit of mapping on the data, and not touched the frontend stuff.
reward.troopandreward.storyObjective. The latter may be campaign related?reward.artifactRewardandpenalty.destroyOwnedBuilding.buildingToDestroyhave default values of0when the event is not related to them. A direct mapping likeartifactTypes[reward.artifactReward]would end up removing the artifact reward attribute, as it lacks a key of0. If we're fine with dropping irrelevant attributes that should be fine, but for now I've usedreward.artifactReward ? artifactTypes[reward.artifactReward] : reward.artifactReward(if non-zero, map, otherwise return 0)