-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
separate wielder skills into "skills" and "startingskills" #56
Conversation
…added `startingSkills` field on WielderDTO, removed command field from `WielderStats.tsx`
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request introduces 1 alert when merging 181bff2 into c6c18a0 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^o^/
Good quality pull request!
It looks like you converted not the most recent Songs of Conquest assets.
Could you update SoC and run the extractor again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
For some reason, the binary data of GOG images are different from the Steam images (or is it related to Linux?). I pushed the steam images, because they didn't change.
convert.mjs
now separates skills intostartingSkills
andskills
WielderDTO.startingSkills
fieldpages/wielders/[type].tsx
WielderStats.tsx
since it's shown in the startingSkills