Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate wielder skills into "skills" and "startingskills" #56

Merged
merged 5 commits into from
Jul 13, 2022

Conversation

Unei95
Copy link
Contributor

@Unei95 Unei95 commented Jul 12, 2022

  • convert.mjs now separates skills into startingSkills and skills
  • added WielderDTO.startingSkills field
  • render startingSkills in own table in pages/wielders/[type].tsx
  • removed "Command" from WielderStats.tsx since it's shown in the startingSkills

…added `startingSkills` field on WielderDTO, removed command field from `WielderStats.tsx`
@vercel
Copy link

vercel bot commented Jul 12, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
soc-gg ✅ Ready (Inspect) Visit Preview Jul 13, 2022 at 4:55AM (UTC)

@Unei95 Unei95 marked this pull request as ready for review July 12, 2022 11:56
@lgtm-com
Copy link

lgtm-com bot commented Jul 12, 2022

This pull request introduces 1 alert when merging 181bff2 into c6c18a0 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

Copy link
Owner

@lmachens lmachens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^o^/
Good quality pull request!

It looks like you converted not the most recent Songs of Conquest assets.
Could you update SoC and run the extractor again?

@Unei95
Copy link
Contributor Author

Unei95 commented Jul 12, 2022

^o^/ Good quality pull request!

It looks like you converted not the most recent Songs of Conquest assets. Could you update SoC and run the extractor again?

I updated to the newest Version available through GOG
image

@lmachens
Copy link
Owner

I have the same version (Steam), but the generated files are differently.
And this pull request reverts some changes of last commits.
You can see it in the termMap.json which doesn't include some new terms.

If you like, I can run the script and push the changes.
Or you check again :).

image

@Unei95
Copy link
Contributor Author

Unei95 commented Jul 12, 2022

i forgot to run assetRipper prior to running the extractor

facepalm

Copy link
Owner

@lmachens lmachens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
For some reason, the binary data of GOG images are different from the Steam images (or is it related to Linux?). I pushed the steam images, because they didn't change.

@lmachens lmachens merged commit 1daf3f2 into lmachens:main Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants