Skip to content

Commit

Permalink
[libc++][vector<bool>] Tests shrink_to_fit requirement. (llvm#98009)
Browse files Browse the repository at this point in the history
`vector<bool>`'s shrink_to_fit implementation is using the
"swap-to-free-container-resources-trick" which only shrinks when the
input vector is empty. Since the request to shrink_to_fit is
non-binding, this is a valid implementation. It is not a high-quality
implementation. Since `vector<bool>` is not a very popular container the
implementation has not been changed and only a test to validate the
non-growing property has been added.

This was discovered while investigating llvm#95161.

(cherry picked from commit c2e4386)
  • Loading branch information
mordante authored and tru committed Jul 24, 2024
1 parent 40af7ee commit a930d1f
Showing 1 changed file with 44 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,54 @@ TEST_CONSTEXPR_CXX20 bool tests()
return true;
}

#if TEST_STD_VER >= 23
template <typename T>
struct increasing_allocator {
using value_type = T;
std::size_t min_elements = 1000;
increasing_allocator() = default;

template <typename U>
constexpr increasing_allocator(const increasing_allocator<U>& other) noexcept : min_elements(other.min_elements) {}

constexpr std::allocation_result<T*> allocate_at_least(std::size_t n) {
if (n < min_elements)
n = min_elements;
min_elements += 1000;
return std::allocator<T>{}.allocate_at_least(n);
}
constexpr T* allocate(std::size_t n) { return allocate_at_least(n).ptr; }
constexpr void deallocate(T* p, std::size_t n) noexcept { std::allocator<T>{}.deallocate(p, n); }
};

template <typename T, typename U>
bool operator==(increasing_allocator<T>, increasing_allocator<U>) {
return true;
}

// https://github.com/llvm/llvm-project/issues/95161
constexpr bool test_increasing_allocator() {
std::vector<bool, increasing_allocator<bool>> v;
v.push_back(1);
std::size_t capacity = v.capacity();
v.shrink_to_fit();
assert(v.capacity() <= capacity);
assert(v.size() == 1);

return true;
}
#endif // TEST_STD_VER >= 23

int main(int, char**)
{
tests();
tests();
#if TEST_STD_VER > 17
static_assert(tests());
#endif
#if TEST_STD_VER >= 23
test_increasing_allocator();
static_assert(test_increasing_allocator());
#endif // TEST_STD_VER >= 23

return 0;
}

0 comments on commit a930d1f

Please sign in to comment.