Integrate Functionalization Pass #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniojkim
force-pushed
the
antoniojkim/functionalization
branch
from
8dd3474 to
e1e30b2
Compare
|
This is exciting! |
|
@silvasean can I get a stamp of approval to merge this into the staging branch? |
silvasean
approved these changes
Jun 30, 2022
antoniojkim
added a commit
that referenced
this pull request
Jun 30, 2022
* Fix autogen build dir issue * Got functionalization pass to compile * Add slice/diagonal backwards functionalization * Fix codegen invocation in CMakeLists.txt * Add functionalization view ops * Fix logsumexp out functionalization * Fix ComputationPtr * Blacklist new_empty op * Add op comparison * Remove unnecessary ops Co-authored-by: Henry Tu <[email protected]>
antoniojkim
added a commit
that referenced
this pull request
Jun 30, 2022
* Fix autogen build dir issue * Got functionalization pass to compile * Add slice/diagonal backwards functionalization * Fix codegen invocation in CMakeLists.txt * Add functionalization view ops * Fix logsumexp out functionalization * Fix ComputationPtr * Blacklist new_empty op * Add op comparison * Remove unnecessary ops Co-authored-by: Henry Tu <[email protected]>
antoniojkim
added a commit
that referenced
this pull request
Jul 5, 2022
* Fix autogen build dir issue * Got functionalization pass to compile * Add slice/diagonal backwards functionalization * Fix codegen invocation in CMakeLists.txt * Add functionalization view ops * Fix logsumexp out functionalization * Fix ComputationPtr * Blacklist new_empty op * Add op comparison * Remove unnecessary ops Co-authored-by: Henry Tu <[email protected]>
antoniojkim
added a commit
that referenced
this pull request
Jul 7, 2022
* Fix autogen build dir issue * Got functionalization pass to compile * Add slice/diagonal backwards functionalization * Fix codegen invocation in CMakeLists.txt * Add functionalization view ops * Fix logsumexp out functionalization * Fix ComputationPtr * Blacklist new_empty op * Add op comparison * Remove unnecessary ops Co-authored-by: Henry Tu <[email protected]>
henrytwo
added a commit
that referenced
this pull request
Jul 8, 2022
* Fix autogen build dir issue * Got functionalization pass to compile * Add slice/diagonal backwards functionalization * Fix codegen invocation in CMakeLists.txt * Add functionalization view ops * Fix logsumexp out functionalization * Fix ComputationPtr * Blacklist new_empty op * Add op comparison * Remove unnecessary ops Co-authored-by: Henry Tu <[email protected]>
henrytwo
added a commit
that referenced
this pull request
Jul 8, 2022
* Fix autogen build dir issue * Got functionalization pass to compile * Add slice/diagonal backwards functionalization * Fix codegen invocation in CMakeLists.txt * Add functionalization view ops * Fix logsumexp out functionalization * Fix ComputationPtr * Blacklist new_empty op * Add op comparison * Remove unnecessary ops Co-authored-by: Henry Tu <[email protected]>
henrytwo
added a commit
that referenced
this pull request
Jul 12, 2022
* Fix autogen build dir issue * Got functionalization pass to compile * Add slice/diagonal backwards functionalization * Fix codegen invocation in CMakeLists.txt * Add functionalization view ops * Fix logsumexp out functionalization * Fix ComputationPtr * Blacklist new_empty op * Add op comparison * Remove unnecessary ops Co-authored-by: Henry Tu <[email protected]>
antoniojkim
added a commit
that referenced
this pull request
Jul 15, 2022
* Fix autogen build dir issue * Got functionalization pass to compile * Add slice/diagonal backwards functionalization * Fix codegen invocation in CMakeLists.txt * Add functionalization view ops * Fix logsumexp out functionalization * Fix ComputationPtr * Blacklist new_empty op * Add op comparison * Remove unnecessary ops Co-authored-by: Henry Tu <[email protected]>
antoniojkim
added a commit
that referenced
this pull request
Jul 19, 2022
* Fix autogen build dir issue * Got functionalization pass to compile * Add slice/diagonal backwards functionalization * Fix codegen invocation in CMakeLists.txt * Add functionalization view ops * Fix logsumexp out functionalization * Fix ComputationPtr * Blacklist new_empty op * Add op comparison * Remove unnecessary ops Co-authored-by: Henry Tu <[email protected]>
antoniojkim
added a commit
that referenced
this pull request
Jul 22, 2022
* Fix autogen build dir issue * Got functionalization pass to compile * Add slice/diagonal backwards functionalization * Fix codegen invocation in CMakeLists.txt * Add functionalization view ops * Fix logsumexp out functionalization * Fix ComputationPtr * Blacklist new_empty op * Add op comparison * Remove unnecessary ops Co-authored-by: Henry Tu <[email protected]>
henrytwo
added a commit
that referenced
this pull request
Jul 29, 2022
* Fix autogen build dir issue * Got functionalization pass to compile * Add slice/diagonal backwards functionalization * Fix codegen invocation in CMakeLists.txt * Add functionalization view ops * Fix logsumexp out functionalization * Fix ComputationPtr * Blacklist new_empty op * Add op comparison * Remove unnecessary ops Co-authored-by: Henry Tu <[email protected]>
henrytwo
added a commit
that referenced
this pull request
Jul 29, 2022
* Fix autogen build dir issue * Got functionalization pass to compile * Add slice/diagonal backwards functionalization * Fix codegen invocation in CMakeLists.txt * Add functionalization view ops * Fix logsumexp out functionalization * Fix ComputationPtr * Blacklist new_empty op * Add op comparison * Remove unnecessary ops Co-authored-by: Henry Tu <[email protected]>
henrytwo
added a commit
that referenced
this pull request
Jul 30, 2022
* Fix autogen build dir issue * Got functionalization pass to compile * Add slice/diagonal backwards functionalization * Fix codegen invocation in CMakeLists.txt * Add functionalization view ops * Fix logsumexp out functionalization * Fix ComputationPtr * Blacklist new_empty op * Add op comparison * Remove unnecessary ops Co-authored-by: Henry Tu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functionalization pass PR has finally landed in upstream PyTorch master. The changes in this PR are what's required to integrate them into the MLIR LTC backend.
@silvasean This is perhaps the last PR required to be merged into the staging branch before we can start considering merging the staging branch into
mainCC: @henrytwo @ke1337