Got LTC working until compile #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. I assume that @wconstab has taken a look at this? Adding them as a reviewer just in case. |
silvasean
approved these changes
Mar 23, 2022
wconstab
reviewed
Mar 24, 2022
| namespace torch { | ||
| namespace lazy { | ||
|
|
||
| std::vector<Shape> compute_shape_detach(const at::Tensor& self) { |
There was a problem hiding this comment.
I'd generally encourage you to upstream these to torch to be shared by all backends; I'm not sure if we want to handle the detach op in other backends though
antoniojkim
added a commit
that referenced
this pull request
May 26, 2022
antoniojkim
added a commit
that referenced
this pull request
Jun 30, 2022
antoniojkim
added a commit
that referenced
this pull request
Jun 30, 2022
antoniojkim
added a commit
that referenced
this pull request
Jul 5, 2022
antoniojkim
added a commit
that referenced
this pull request
Jul 7, 2022
henrytwo
pushed a commit
that referenced
this pull request
Jul 8, 2022
henrytwo
pushed a commit
that referenced
this pull request
Jul 8, 2022
henrytwo
pushed a commit
that referenced
this pull request
Jul 12, 2022
antoniojkim
added a commit
that referenced
this pull request
Jul 15, 2022
antoniojkim
added a commit
that referenced
this pull request
Jul 19, 2022
antoniojkim
added a commit
that referenced
this pull request
Jul 22, 2022
henrytwo
pushed a commit
that referenced
this pull request
Jul 29, 2022
henrytwo
pushed a commit
that referenced
this pull request
Jul 29, 2022
henrytwo
pushed a commit
that referenced
this pull request
Jul 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in this PR get the Torch-MLIR LTC Backend to a point where an example run can successfully run up until the actual compile. This means that the graph is properly traced with the Torch-MLIR LTC backend and is ready to be compiled.
Next steps is to implementing the lowering itself down to MLIR from the LTC Node IR representation. The idea is to make use of a lot of the existing TorchScript IR -> MLIR infrastructure that already exists to make it easier to integrate.
CC: @ke1337 @henrytwo