Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring the C++ ONNX importer on par with onnx_importer.py #3960

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
c9e38c6
Add Constant value attr handler, add none constant, remove ConstantOf…
giacs-epic Dec 3, 2024
85a8c2f
Port up to ImportGeneralNode()
giacs-epic Jan 14, 2025
b3e1a15
Finish port
giacs-epic Jan 14, 2025
b56bae2
Add checks before map insertions
giacs-epic Jan 15, 2025
e9b7e11
Port command line arguments and loadOnnxModel()
giacs-epic Jan 15, 2025
840b280
Update SanitizeNameAsIdentifier() routine
giacs-epic Jan 15, 2025
523cd45
Remove most onnx calls in import-onnx-main
giacs-epic Jan 16, 2025
84ed038
Switch to c++20
giacs-epic Jan 16, 2025
db756b0
Switch to SimpleArgParser. Enable exceptions for ONNX.
giacs-epic Jan 20, 2025
16ee4ad
Fix usage reporting
giacs-epic Jan 21, 2025
94fcf0e
Remove usage of LLVM support lib
giacs-epic Jan 21, 2025
90d16a6
Fix name sanitization and accessibility of module's func.
giacs-epic Jan 21, 2025
f72aef0
Add Dict to replace unordered_map usages
giacs-epic Jan 22, 2025
732e96a
Remove debug print
giacs-epic Jan 22, 2025
7eecd13
Fix a couple of out-of-scope memory accesses bugs
giacs-epic Jan 23, 2025
d3b13d0
Fix ordering of sub-blocks. Fix TypeProto nullptr handling.
giacs-epic Jan 23, 2025
fc7841e
Fix missing calls to Initialize()
giacs-epic Jan 23, 2025
288999f
Comment out debug check_model
giacs-epic Jan 23, 2025
fd8a351
Merge branch 'main' into update_c_onnx_importer
giacs-epic Jan 27, 2025
e29aa97
Fix several bugs arising from operator tests
giacs-epic Jan 28, 2025
c52f4cd
Fix missing implementation in GraphInfo and minor bugs.
giacs-epic Jan 29, 2025
c8cd855
Change comment of dense bool conversion
giacs-epic Jan 31, 2025
a126229
Fix shapes not being inferred before version conversion.
giacs-epic Jan 31, 2025
154739c
onnx_importer.py: fix dim_value None not correctly processed
giacs-epic Feb 6, 2025
f319fe3
Removed check_model() (not actually used in onnx_importer.py)
giacs-epic Feb 7, 2025
bdf64cd
Add external data loading.
giacs-epic Feb 10, 2025
9f7257e
Merge commit 'c9694c6' into update_c_onnx_importer
giacs-epic Feb 13, 2025
0655791
Clean up
giacs-epic Feb 14, 2025
6326092
Fix InferShapes uncaught exceptions
giacs-epic Feb 17, 2025
944ab77
Merge branch 'main' into update_c_onnx_importer
giacs-epic Feb 17, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove debug print
giacs-epic committed Jan 22, 2025
commit 732e96a8a214290d37aabc583964b3138fa50666
1 change: 0 additions & 1 deletion projects/onnx_c_importer/OnnxImporter.cpp
Original file line number Diff line number Diff line change
@@ -341,7 +341,6 @@ Status ModelInfo::Initialize() {
Status GraphInfo::Initialize() {
// Initialize look up tables.
for (const onnx::TensorProto &t : graph_proto_.initializer()) {
std::cout << t.name() << "\n";
if (initializer_map_.find(t.name()) != initializer_map_.end()) {
return model_info_.SetError("ONNX initializer name already used: " +
t.name());