Added support for Maxpool (Autopad) #3774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivekkhandelwal1
requested changes
Oct 10, 2024
…e reviewer comment
|
@vivekkhandelwal1 : I have made the necessary changes and pushed in the latest commit. Could you review it again. Thanks. |
vivekkhandelwal1
requested changes
Oct 16, 2024
There was a problem hiding this comment.
Except that one comment, I would also like you to add a lit test here https://github.com/llvm/torch-mlir/blob/main/test/Conversion/TorchOnnxToTorch/simple_ops_g_to_p.mlir for the given feature to be tested. Rest all, looks good to me.
…me_lower, same_upper, precomputed_same_upper
vivekkhandelwal1
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Hi @sriram-siloai, thanks for the patch. This patch can be merged once you address that last comment.
I hope the padding is also numerically correct. If you find some time, then please try to add an E2E test here: https://github.com/nod-ai/SHARK-TestSuite/ to test the robustness of your patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added autopad. and passed 3 tests
test_maxpool_2d_precomputed_same_upper
test_maxpool_2d_same_lower'
test_maxpool_2d_same_upper
Address : nod-ai/SHARK-ModelDev#843
2 attributes yet to complete : storage_order, indices output