[TorchToLinalg] remove extract_slice grid_sample lowering
#3483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanWood1
force-pushed
the
grid_sampler_index_maps
branch
from
43ce1a0 to
9f43e04
Compare
IanWood1
force-pushed
the
grid_sampler_index_maps
branch
from
9f43e04 to
77f4eea
Compare
6 tasks
zjgarvey
reviewed
Jul 5, 2024
|
Hi @IanWood1, can you please address the comment and update the PR? |
updated! |
zjgarvey
approved these changes
Aug 20, 2024
|
@IanWood1 If you don't have merge permissions, let me know and I'll squash and merge this when you are ready. |
IanWood1
changed the title
extract_slice from lowering of grid_sampleextract_slice grid_sample lowering
|
@zjgarvey I just got them last week, but thank you. and thanks for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using extract_slice for grid sampler, use affine constants to access the X and Y values in the generic op's region.