-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement lowering of torch.aten.all.dim #2873
Conversation
Initial lowering torch.aten.all.dim Handle ui8 case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but I think the tests can be more targeted (smaller tensor, set values by hand). Can you test the empty tensor case returns 'True' ?
@newling done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the tests, just the isa<.> comment remaining
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the little comment about the extra brackets and formatting, but approving now as it looks good to me otherwise.
@newling can you merge this PR? I do not have write access :) |
My view of the PR: @mmakevic Let me know if this looks correct ("authored by" email look ok?) and I'll merge it if no one else comments in the next day. |
@newling Yeah, everything looks okay. Thanks! |
Lowering of torch.aten.all.dim to linalg.
Per PyTorch documentation:
Since there is no support for ui8 in torch-mlir currently (#1384 (comment)) implementation returns failure for that case.