Replace RefineTypes with dtype functions #2105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramiro050
force-pushed
the
merge-main-full-squash
branch
from
e81b862 to
2c0c953
Compare
ramiro050
commented
May 9, 2023
lib/Dialect/Torch/Transforms/SimplifyAbstractInterpCalculationsUtils.cpp
Show resolved
Hide resolved
python/torch_mlir/dialects/torch/importer/jit_ir/build_tools/abstract_interp_lib_gen.py
Show resolved
Hide resolved
python/torch_mlir/dialects/torch/importer/jit_ir/build_tools/testing_framework.py
Show resolved
Hide resolved
23 tasks
silvasean
approved these changes
May 12, 2023
python/torch_mlir/dialects/torch/importer/jit_ir/build_tools/library_generator.py
Outdated
Show resolved
Hide resolved
|
Big thanks to Jiahao Li and any others that helped with this migration! ❤️ |
This commit adds dtype functions for all the torch ops that did not previously have one and removes the pass `RefineTypes`, since the abstract interpretation library now takes care of all the dtype propagation. All dtype functions added are tested except for - `aten.embedding` - `aten._embedding_bag` - `aten.embedding_bag` These functions need a change to the testing framework to allow specifying the actual data inside the tensor used for testing. I will fix this in a follow up patch. Co-authored-by: Jiahao Li <[email protected]>
ramiro050
force-pushed
the
merge-main-full-squash
branch
from
2c0c953 to
706e505
Compare
23 tasks
gpetters94
pushed a commit
to gpetters94/mlir-npcomp
that referenced
this pull request
Jul 7, 2023
This commit adds dtype functions for all the torch ops that did not previously have one and removes the pass `RefineTypes`, since the abstract interpretation library now takes care of all the dtype propagation. All dtype functions added are tested except for - `aten.embedding` - `aten._embedding_bag` - `aten.embedding_bag` These functions need a change to the testing framework to allow specifying the actual data inside the tensor used for testing. I will fix this in a follow up patch. Co-authored-by: Jiahao Li <[email protected]>
gpetters94
pushed a commit
to gpetters94/mlir-npcomp
that referenced
this pull request
Jul 7, 2023
This commit adds dtype functions for all the torch ops that did not previously have one and removes the pass `RefineTypes`, since the abstract interpretation library now takes care of all the dtype propagation. All dtype functions added are tested except for - `aten.embedding` - `aten._embedding_bag` - `aten.embedding_bag` These functions need a change to the testing framework to allow specifying the actual data inside the tensor used for testing. I will fix this in a follow up patch. Co-authored-by: Jiahao Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds dtype functions for all the torch ops that did not previously have one and removes the pass
RefineTypes, since the abstract interpretation library now takes care of all the dtype propagation.All dtype functions added are tested except for
aten.embeddingaten._embedding_bagaten.embedding_bagThese functions need a change to the testing framework to allow specifying the actual data inside the tensor used for testing. I will fix this in a follow up patch.
Co-authored-by: Jiahao Li [email protected]