Add miscellaneous dtype functions #2090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 tasks
|
Would you make the CI pass? Maybe re-running it would help. |
ramiro050
force-pushed
the
add-misc-dtype-funcs
branch
2 times, most recently
from
ccedcdb to
72b156d
Compare
This commit moves the `FullyUnrollPrimLoopOp`, `FoldPrimUncheckedCastOp` and `AbstractlyInterpretListOpsWithinABlock` patterns to the `SimplifyAbstractInterpCalculationsUtils.cpp` file so that the dtype simplification pipeline can also use them. In addition, the `Aten__Getitem__TOp` and `PrimTupleUnpackOp` canonicalizers are added to the dtype simplification pipeline to deal with the ops generated by the `aten.cat` dtype function.
This commit adds dtype functions for: - AtenAtan2Op - AtenLinearOp - AtenMaxPool2dWithIndicesOp - AtenCatOp - Aten_ShapeAsTensorOp - AtenScalarImplicitOp - PrimNumToTensorScalarOp
ramiro050
force-pushed
the
add-misc-dtype-funcs
branch
from
72b156d to
49cc402
Compare
Done! @li-plus, PTAL |
ramiro050
commented
May 5, 2023
|
|
||
| using namespace mlir; | ||
| using namespace mlir::torch; | ||
| using namespace mlir::torch::Torch; | ||
|
|
||
| namespace { |
There was a problem hiding this comment.
FYI: all the patterns added here came from SimplifyShapeCalculations.cpp and have not been modified in any way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the
FullyUnrollPrimLoopOp,FoldPrimUncheckedCastOpandAbstractlyInterpretListOpsWithinABlockpatterns to the
SimplifyAbstractInterpCalculationsUtils.cppfile sothat the dtype simplification pipeline can also use them.
In addition, the
Aten__Getitem__TOpandPrimTupleUnpackOpcanonicalizers are added to the dtype simplification pipeline to deal
with the ops generated by the
aten.catdtype function.Lastly, the dtype functions for the following ops are added: