Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more dtype funcs #1962

Merged
merged 4 commits into from
Mar 23, 2023
Merged

Add more dtype funcs #1962

merged 4 commits into from
Mar 23, 2023

Conversation

ramiro050
Copy link
Collaborator

This PR adds dtype functions for:

  • aten.bincount
  • "Promote three dtypes"
  • "Promote LHS with scalar RHS"
  • "Promote 2nd and 3rd Operands"

Each addition is made in its own commit to make review easier.

@ramiro050 ramiro050 mentioned this pull request Mar 22, 2023
Closed
23 tasks
@ramiro050 ramiro050 marked this pull request as ready for review March 22, 2023 18:59
@ramiro050 ramiro050 requested a review from li-plus March 22, 2023 18:59
li-plus
li-plus approved these changes Mar 23, 2023
View reviewed changes
Copy link
Collaborator

@li-plus li-plus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ramiro050 ramiro050 merged commit 2793c9f into llvm:dtype-functions-staging Mar 23, 2023
@ramiro050 ramiro050 deleted the add-more-dtype-funcs branch March 23, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@li-plus li-plus li-plus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ramiro050 @li-plus